Skip to content

Demo clickhouse aa#6

Open
alisman wants to merge 29 commits into
clickbasefrom
demo-clickhouse-aa
Open

Demo clickhouse aa#6
alisman wants to merge 29 commits into
clickbasefrom
demo-clickhouse-aa

Conversation

@alisman

@alisman alisman commented Mar 8, 2024

Copy link
Copy Markdown
Owner

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • a
  • b

Checks

  • Runs on heroku
  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

pvannierop and others added 29 commits March 15, 2023 21:36
- Add versionRange to pom.xml to conform to specifications
- Add ClickHouseDB query for retrieving sample_ids from sample table based on attribute
…nd mutated genes (cBioPortal#10213)

Co-authored-by: Bryan Lai <laib1@mskcc.org>
* revert study view controller original endpoints and rename clickhouse endpoints

* add mybatiscolumnstore to test application context
…BioPortal#10245)

* Extract column store endpoints into StudyViewControllerColumnStore

* rename
Migrate mutated-genes and clinical-data-counts to clickhouse-ish implementations
---------

Co-authored-by: haynescd <haynescd@chop.edu>
* Fix test to add Clinical Data

* Fix GeneFilters
@Nitish-Naik

Copy link
Copy Markdown

hello mentor @alisman,
i am working on this Re-implement Study View's data binning algorithm using SQL (instead of Java) cBioPortal#117
but I'm getting setup issues can you guide me how to setup??
1.. like I need to setup only backend. If yes how do I test modified logic code?
I had no other way to contact you so I used this.. Sorry for that..
Eagerly waiting for you response.
Thanks in advance.
Nitish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants