Skip to content

fix: the trigger test builds its instance under a name of its own - #103

Merged
alkhatibdev merged 1 commit into
mainfrom
trigger-image-names
Nov 17, 2026
Merged

alkhatibdev merged 1 commit into
mainfrom
trigger-image-names

Conversation

@alkhatibdev

Copy link
Copy Markdown
Owner

The trigger test builds its instance under a name of its own

Since the compose file names each image after DPOLENS_VERSION (#37), the trigger test's
docker compose up --build has tagged the instance it builds from a checkout as the release the
compose file names: ghcr.io/alkhatibdev/dpolens:0.2.0, and the same for the MCP server, the
dashboard and Postgres. A batch replaced whatever that machine held under those names, so an
instance started afterwards from the release, without --build, would run the checkout under
test.

--reuse-images had the other half of the problem: it checked images named
dpolens-trigger-api and dpolens-trigger-mcp, which the compose file stopped building, and
then started the release-named ones. It vouched for different images than it ran.

What changes

  • The instance is built as trigger-test, whatever DPOLENS_VERSION the shell holds.
  • --reuse-images checks the images the compose file builds under that name.
  • evals/trigger/README.md says so where it describes --reuse-images.

The published numbers were measured on 8 and 9 October, before #37, so they are not affected.

Tests

  • The instance is built as trigger-test with DPOLENS_VERSION=0.2.0 in the environment, and
    that name cannot be read as a release number.
  • The images --reuse-images checks are the ones compose.yaml builds for those services under
    that name, read from the file.

Both fail on main.

Signed-off-by: alkhatibdev <me@alkhatib.dev>
@alkhatibdev
alkhatibdev merged commit 76888d5 into main Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant