Repository navigation
fix: the trigger test builds its instance under a name of its own - #103
Merged
Merged
Conversation
Signed-off-by: alkhatibdev <me@alkhatib.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trigger test builds its instance under a name of its own
Since the compose file names each image after
DPOLENS_VERSION(#37), the trigger test'sdocker compose up --buildhas tagged the instance it builds from a checkout as the release thecompose file names:
ghcr.io/alkhatibdev/dpolens:0.2.0, and the same for the MCP server, thedashboard and Postgres. A batch replaced whatever that machine held under those names, so an
instance started afterwards from the release, without
--build, would run the checkout undertest.
--reuse-imageshad the other half of the problem: it checked images nameddpolens-trigger-apianddpolens-trigger-mcp, which the compose file stopped building, andthen started the release-named ones. It vouched for different images than it ran.
What changes
trigger-test, whateverDPOLENS_VERSIONthe shell holds.--reuse-imageschecks the images the compose file builds under that name.evals/trigger/README.mdsays so where it describes--reuse-images.The published numbers were measured on 8 and 9 October, before #37, so they are not affected.
Tests
trigger-testwithDPOLENS_VERSION=0.2.0in the environment, andthat name cannot be read as a release number.
--reuse-imageschecks are the onescompose.yamlbuilds for those services underthat name, read from the file.
Both fail on
main.