Repository navigation
fix: the skill says personal data for what is sent to another service - #107
Merged
Merged
Conversation
Signed-off-by: alkhatibdev <me@alkhatib.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skill says personal data for what is sent to another service
service". It now says "when sending personal data to another service", as the server's
instructions and the tool descriptions do. In the published trigger test, the plugin searched
on a page view sent to Segment, which carries data about no one, in all three runs, where the
MCP server on its own never did.
trigger sentence, and
search_policieson a self-hosted instance and on a community version)and fails on a bare "data". The lines are joined first, so "personal" at the end of one line
and "data" at the start of the next stay one phrase. On
mainit fails on the skill'sdescription, and only there.
evals/trigger-test.mdreplaces "the likely reason" with what was found and measured. Thepage-view task had two ways in: the word, and in one run the plugin's
/policy-checkcommand,which Claude Code ran on its own. With this change alone, the plugin arm was run again: 36 of
36 (all before the first edit), 1 of 45 and 9 of 9. The page-view task never searched and
/policy-checknever ran. The one unneeded search wassession-length, in one run of three.Checked
claude-sonnet-5-5, from1acbf05with only the skill's change, on 17 and 18 November. It isnot written to
evals/results/trigger.json: it ran before fix: the trigger test's instance chooses the law its searches cover #104, so its instance had no lawchosen and every search came back as an error, which
--writerefuses. The published resultstays October's. What it counts is the call, which comes before any answer, so the counts hold.
ruff format --check, mypy, the import contracts,scripts/client_text.pyand thewhole test suite with the integration tests (1501 passed) in a clean copy, with caches off and
GITHUB_ACTIONS=true. The new test fails onmainand passes here.