fix(cache-manager): await an awaitable returned by the get_or_set factory - #133
Merged
Merged
Conversation
…tory get_or_set() awaited the factory only when it was a coroutine function, so the documented lambda: load_user(42) form stored the coroutine and failed with TypeError. The factory is now called and its result awaited whenever it is awaitable. Closes #101
allen0099
force-pushed
the
fix/get-or-set-awaitable
branch
from
September 25, 2026 10:55
91dfcf2 to
bc12389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101.
Problem
get_or_set()awaited the factory only wheninspect.iscoroutinefunction(factory)was true. The example indocs/APP_CACHE.md,get_or_set("user:42", lambda: load_user(42), ttl=300), passes a lambda that returns a coroutine. That coroutine went toset(), which failed withTypeError: Object of type coroutine is not JSON serializableand emitted a "never awaited" warning.Changes
get_or_set()calls the factory and awaits the result wheninspect.isawaitable(result). This covers async functions, lambdas andfunctools.partialwrapping them, and async callables.factorydocstring says so.[Unreleased]Fixed entry.Tests
test_get_or_set_awaits_a_sync_callable_returning_an_awaitableis parametrized over a lambda and afunctools.partial:iscoroutinefunctionunwraps partials. It stays as a guard.Local results:
zensical build --strict: passes.CACHEX_REQUIRE_LIVE_SERVERS=1against Redis and Memcached: 720 passed, 100% coverage.