fix(session): match the Bearer scheme case-insensitively - #195
Merged
Merged
Conversation
Authentication scheme names are case-insensitive (RFC 9110 11.1), but the middleware only recognised the exact "Bearer " prefix, so a client sending "bearer <token>" got no session. Accept one or more spaces before the token (RFC 6750 2.1), and yield no token for a header that carries none. Closes #166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166.
Problem
The session middleware (
FastAPICacheXSessionMiddlewareand the deprecatedSessionMiddleware, through_extract_header_token) read the bearer token withauth_header.startswith("Bearer "). Authentication scheme names are case-insensitive (RFC 9110 §11.1), so these headers got no session:AuthorizationBearer tok"tok""tok"bearer tok/BEARER tokNone"tok"Bearer tok(two spaces, allowed by RFC 6750 §2.1)" tok""tok"Bearer""NoneChange
token_source_priority, as an empty custom header already does.Tests
middleware.pycoverage stays at 100%.