Skip to content

Fix workflow errors: missing services, deprecated commands, and exception handling - #2

Closed
allen0099 with Copilot wants to merge 3 commits into
masterfrom
copilot/fix-workflow-errors
Closed

allen0099 with Copilot wants to merge 3 commits into
masterfrom
copilot/fix-workflow-errors

Conversation

Copilot AI commented Dec 15, 2025 •

Copy link
Copy Markdown

The workflows had multiple issues: the tox workflow was missing Redis and Memcached services, the publish workflow used deprecated GitHub Actions syntax, and Redis connection tests were crashing with unhandled exceptions when Redis was unavailable.

Changes

  • .github/workflows/tox.yml: Added Redis and Memcached service containers to match test.yml and coverage.yml configurations
  • .github/workflows/publish.yml: Replaced deprecated ::set-output command with $GITHUB_OUTPUT environment file approach to resolve GitHub Actions deprecation warnings
  • tests/backends/test_redis.py: Expanded exception handling in is_redis_running() to catch ConnectionRefusedError and OSError in addition to TimeoutError
# Before: Only caught TimeoutError
except TimeoutError:
    return False

# After: Catches all connection errors
except (ConnectionRefusedError, OSError, TimeoutError):
    return False

Tests now skip gracefully when services are unavailable instead of failing with unhandled exceptions, and all workflows use current GitHub Actions syntax without deprecation warnings.

Original prompt

This section details on the original issue you should resolve

<issue_title>修正 Workflow 中的錯誤</issue_title>
<issue_description>修正目前 workflow 中的錯誤</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ndling

Co-authored-by: allen0099 <22383656+allen0099@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix errors in the current workflow Fix tox workflow failures due to missing Redis/Memcached services Dec 15, 2025
Copilot AI requested a review from allen0099 December 15, 2025 10:10
@allen0099

Copy link
Copy Markdown
Owner

@copilot 修正 workflow 錯誤

Co-authored-by: allen0099 <22383656+allen0099@users.noreply.github.com>

Copilot AI commented Dec 15, 2025

Copy link
Copy Markdown
Author

@copilot 修正 workflow 錯誤

Workflow errors fixed in commit 0b92552. Changes include:

  • Added Redis/Memcached services to tox.yml
  • Improved exception handling in test_redis.py
  • Replaced deprecated set-output with $GITHUB_OUTPUT in publish.yml

All workflows should now run without errors.

Copilot AI changed the title Fix tox workflow failures due to missing Redis/Memcached services Fix workflow errors: missing services, deprecated commands, and exception handling Dec 15, 2025
Copilot AI requested a review from allen0099 December 15, 2025 16:03
@allen0099 allen0099 closed this Dec 16, 2025
@allen0099
allen0099 deleted the copilot/fix-workflow-errors branch July 6, 2026 16:15
ShivanshShukla added a commit to ShivanshShukla/FastAPI-CacheX that referenced this pull request Sep 25, 2026
…len0099#64)

- Set _is_held = True synchronously at entry of acquire() before the first await to prevent shared-instance race conditions.
- Format CHANGELOG.md entries with bold summaries and link allen0099#64 on both.
- Revert zensical.zh-TW.toml edit.
- Update docs/LOCK.md to detail TTL expiration behavior and default timeout=None indefinite blocking.
- Move PYI034 ignore inline on __aenter__ line in lock.py.
- Update test_lock_shared_instance_raises_runtime_error in tests/test_lock.py to use YieldingMemoryBackend.
ShivanshShukla added a commit to ShivanshShukla/FastAPI-CacheX that referenced this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

修正 Workflow 中的錯誤

2 participants