feat: export CacheXError, BackendNotFoundError and RequestNotFoundError - #207
Merged
Merged
Conversation
@cache and the proxies raise these exceptions, but unlike every session and state exception they were only importable from fastapi_cachex.exceptions. Re-export them from the package next to LockTimeoutError. Closes #160
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160
Summary
@cacheand the proxies raiseCacheXError,BackendNotFoundErrorandRequestNotFoundError. Unlike every session and state exception, they could only be imported fromfastapi_cachex.exceptions. They are now re-exported fromfastapi_cachex, next toLockTimeoutError, and added to__all__. The docs have no list of importable names, so they are unchanged.Tests
tests/test_exports.pychecks that each name is infastapi_cachex.__all__and is the same object as infastapi_cachex.exceptions. Against master's__init__.py, only these three cases fail.mypy --strict, full suite against live Redis and Memcached (CACHEX_REQUIRE_LIVE_SERVERS=1): 864 passed.CHANGELOG entry
Section: Added. The entry is added in #206.