refactor(manager): encode the JSON content once in CacheManager._encode - #210
Merged
Merged
Conversation
_encode encoded the JSON string once for the fingerprint and again for the stored content. Encode it once and hash the same bytes. str.encode() already defaults to UTF-8, so the stored entry is unchanged. Closes #183
allen0099
added
enhancement
18 of 20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183
Summary
CacheManager._encodeencoded thejson.dumpsresult twice: once to hash it for the fingerprint, and once for the stored content. It now encodes once and hashes the same bytes.str.encode()already defaults to UTF-8, so the fingerprint and the content are byte-for-byte the same as before.Tests
CacheManagertests cover_encode.mypy --strict, full suite against live Redis and Memcached (CACHEX_REQUIRE_LIVE_SERVERS=1): 861 passed.CHANGELOG entry
None (internal refactor).