feat(proxy): raise ProxyNotSetError from unset manager proxies - #220
Merged
Merged
Conversation
CacheManagerProxy, SessionManagerProxy and StateManagerProxy raised BackendNotFoundError from get() when no instance was set, although no backend is involved. They now raise ProxyNotSetError, a subclass of BackendNotFoundError, so existing handlers keep working. BackendProxy still raises BackendNotFoundError. The lazy dependencies catch the narrower error, and ProxyNotSetError is exported from the package. Closes #161
allen0099
force-pushed
the
feat/proxy-not-set-error
branch
from
September 26, 2026 18:29
54b0539 to
2246b2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161 (part of #113)
Problem
ProxyBase.get()raisedBackendNotFoundErrorfor every proxy.CacheManagerProxy,SessionManagerProxyandStateManagerProxyhave nothing to do with a backend, so a missing session manager surfaced as "backend not found".Change
ProxyNotSetError(BackendNotFoundError)infastapi_cachex.exceptions, exported fromfastapi_cachex.except BackendNotFoundErrorworking.ProxyBaseraisescls._not_set_error, which defaults toProxyNotSetError.BackendProxyoverrides it withBackendNotFoundError, so its behaviour does not change. A third-partyProxyBasesubclass gets the new error.get_app_cacheandget_state_managernow catchProxyNotSetErrorrather thanBackendNotFoundErroraround the manager proxy lookup. This makes explicit that only a missing manager triggers the lazy default.Tests
tests/test_proxybackend.py:ProxyNotSetError, which is also aBackendNotFoundError;BackendProxystill raises plainBackendNotFoundError.tests/test_exports.pylistsProxyNotSetError.Mutation checks:
BackendNotFoundErrorBackendProxyoverrideBackendProxytestProxyNotSetErrornot aBackendNotFoundErrorsubclassRuff,
mypy --strict, the full suite against live Redis and Memcached (902 passed), andzensical build --strictfor both languages.