feat(session): derive SessionError from CacheXError - #223
Merged
Merged
Conversation
SessionError derived from Exception while StateError derived from CacheXError, so except CacheXError caught state errors but not session errors. SessionError still is an Exception, so existing handlers keep working. Closes #162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162. Part of #113.
SessionErrorderived fromException, whileStateErrorderives fromCacheXError, soexcept CacheXErrorcaught state errors but not session errors. It now derives fromCacheXError.SessionErrororExceptionkeep working. FastAPI/Starlette exception handlers are looked up by the most specific class, so a registeredSessionErrorhandler still wins over aCacheXErrorone.tryblock that listsexcept CacheXErrorbeforeexcept SessionErrornow takes theCacheXErrorbranch for session errors. The CHANGELOG entry (under### Changed) says so. No code in the library catchesCacheXError.docs/SESSION.mdand its zh-TW translation mention the new base class.Tests
test_session_errors_are_caught_as_cachex_errorsintests/session/test_manager.py. WithSessionErrorreverted toException, it is the only test that fails.mypy --strict, the changelog format test and both--strictdocs builds pass.