docs(changelog): correct the warning claims in the #126 and #256 fragments - #369
Merged
Merged
Conversation
allen0099
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two 0.3.9 changelog fragments describe warnings that the code does not emit that way. Both go into the 0.3.9 CHANGELOG and release notes as written, so they should be fixed before the release.
changelog.d/256.deprecated.mdsaid "Header-only setups never send the cookie and do not warn".FastAPICacheXSessionMiddlewarewarns whenevercookie_nameorcookie_https_onlyis left at the default, however clients send the token. The sentence now says so.changelog.d/126.deprecated.mdsaid that passingencodingtoAsyncRedisCacheBackendemits aDeprecationWarning. Only a UTF-8 value does. Any other value gets only the existingRuntimeWarning, which already announces the removal. Settingencodingon aRedisConfiggiven toload_from_config()warns for any value, as before.Changelog fragments only; no code changes. Found during the docs audit (#359–#361, #367).