fix(state): treat non-object and oversized-integer JSON as malformed state - #381
Merged
Merged
Conversation
…state _decode_state caught only ValueError around StateData(**...) and only JSONDecodeError around json.loads, so a stored state that was JSON but not an object escaped as TypeError, and one holding an integer past the interpreter's digit limit escaped as ValueError. validate_state, get_state_metadata and consume_state now treat both as malformed data. Fixes #368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #368.
StateManager._decode_statelet two kinds of malformed stored state escape as the wrong exception:[1, 2],"x",1,null):StateData(**...)raisedTypeError, and onlyValueErrorwas caught.sys.int_info.default_max_str_digits(4300 by default), top-level or nested:json.loadsraised a plainValueError, and onlyJSONDecodeErrorwas caught.Both now raise
StateDataError, so the three public methods behave as documented for malformed data:validate_state()returnsFalse,get_state_metadata()returnsNone, andconsume_state()raisesStateDataError(the entry is deleted, as before).The non-object case is checked with
isinstance(..., dict)afterjson.loadsrather than by also catchingTypeError, so the error names the problem and an unrelatedTypeErrorfrom the model is not swallowed. The oversized-integer case came up while reviewing this fix.Tests
changelog.d/368.fixed.md.