Repository navigation
feat!: remove the unused CacheError exception - #399
Merged
Merged
Conversation
fastapi_cachex.exceptions.CacheError was never raised and has emitted a DeprecationWarning since 0.3.8. Catch CacheXError instead. Closes #130
allen0099
added
breaking-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130.
fastapi_cachex.exceptions.CacheErrorwas never raised and has been deprecated since 0.3.8. This PR removes:TYPE_CHECKINGalias and the module__getattr__shim;docs/api/types.md;tests/test_exceptions.py, whose three tests covered only the shim.CacheErrorwas never exported fromfastapi_cachex.Migration: catch
CacheXError, the base of every library exception.Changelog:
changelog.d/130.removed.md.