Repository navigation
feat(session)!: make UserSessionDep require a session with a user - #403
Merged
Merged
Conversation
UserSessionDep was Depends(get_session) and admitted anonymous sessions despite its name. Resolve it through require_user_session, like AuthenticatedSession, so an anonymous session gets 401. Parametrize the anonymous-session test over both annotations and update the session docs, which described it as an alias until 0.4.0. BREAKING CHANGE: UserSessionDep requires a user; routes that should admit anonymous sessions use SessionDep.
allen0099
added
session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127.
UserSessionDepwas an alias ofSessionDep, so it also accepted anonymous sessions. It is nowAnnotated[Session, Depends(require_user_session)], the same asAuthenticatedSession: an anonymous session gets401.test_require_user_session_rejects_anonymous_sessionsis parametrized overAuthenticatedSessionandUserSessionDep. TheUserSessionDepcase fails with the old alias.SESSION.mdis updated in EN and zh-TW. No example or snippet usesUserSessionDepon a route meant for anonymous sessions.Migration: a route that should keep accepting anonymous sessions uses
SessionDep.Checks
Changelog:
changelog.d/127.changed.md.