Conversation
JWTTokenSerializer raises ValueError when jwt_algorithm is HS384 or HS512 and secret_key is shorter than 48 or 64 UTF-8 bytes (RFC 7518 section 3.2). The check runs before PyJWT is imported, so the configuration error comes first. A custom token_serializer holds its own key and is not checked. BREAKING CHANGE: a SessionManager with token_format="jwt", HS384/HS512 and a short secret_key no longer starts. 0.3.x warned with a UserWarning; use a longer key or HS256. Closes #129
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129
Summary
JWTTokenSerializer(and soSessionManagerwithtoken_format="jwt") raisesValueErrorwhenjwt_algorithmisHS384orHS512andsecret_keyis shorter than 48 or 64 bytes in UTF-8 (RFC 7518 §3.2). This replaces the 0.3.xUserWarning.jwtextra.token_serializerholds its own key and is not checked. HS256 is unaffected (SessionConfigalready requires 32 characters).SESSION.mdandMIGRATING_0_4.md#jwt-secret(en/zh-TW); changelog fragment129.changed.md.Tests
SessionManageris built, before PyJWT is needed, and a custom serializer bypassing the check.<=instead of<, counting characters instead of bytes, dropping the raise, and moving the check after the PyJWT import each fail a test.