feat: add CacheManager.add() for atomic store-if-absent - #83
Closed
HarshRajSinghania wants to merge 1 commit into
Closed
HarshRajSinghania wants to merge 1 commit into
HarshRajSinghania wants to merge 1 commit into
Conversation
Implements allen0099#65. add() uses the same prefix, JSON encoding and default_ttl as set(), and delegates to backend.set_if_absent. Signed-off-by: Harsh Raj Singhania <harshrajsinghania@proton.me>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
CacheManager.add(key, value, ttl=None) -> boolso application code can store a JSON-serializable value only when the key is still free.Motivation
Requested in #65.
CacheManageralready exposesget/set/delete/has/get_or_set, and backends already implement atomicset_if_absent(#62). This is the application-level wrapper for once-only writes (webhook/email dedup, first-occurrence recording, idempotency keys).Implementation
default_ttlhandling asset().backend.set_if_absent(atomic on Memory, Redis, and Memcached).TypeError, matchingset().Testing
Added tests in
tests/test_cache_manager.py:default_ttlTypeErrorfor non-JSON valuesThe environment used for this change could not install FastAPI from the configured PyPI mirror (502s), so the full pytest suite was not run here.
add()was checked againstMemoryBackendwith a stubbed FastAPI import; all four behaviors above passed.Closes #65