Skip to content

docs(state): correct create_state error contract - #90

Closed
1cbyc wants to merge 1 commit into
allen0099:masterfrom
1cbyc:1cbyc/88-correct-create-state-errors
Closed

1cbyc wants to merge 1 commit into
allen0099:masterfrom
1cbyc:1cbyc/88-correct-create-state-errors

Conversation

@1cbyc

@1cbyc 1cbyc commented Sep 25, 2026

Copy link
Copy Markdown

Summary

  • replace the incorrect StateDataError claim on create_state()
  • document that configured backend exceptions propagate unchanged

This keeps the documented API contract aligned with the existing non-wrapping implementation.

Fixes #88

Validation

  • uv run zensical build --strict
  • uv run pytest --cov=fastapi_cachex --cov-report=term-missing — 520 passed, 146 skipped, 91.89% coverage
  • uv run ruff check .
  • uv run ruff format --check .
  • uv run mypy fastapi_cachex --strict
  • uv run mypy tests
  • uv run mypy scripts
  • uv build

Co-authored-by: insisong emmanuelisaacnsisong@gmail.com

Co-authored-by: insisong <emmanuelisaacnsisong@gmail.com>
@1cbyc

1cbyc commented Sep 25, 2026

Copy link
Copy Markdown
Author

Upstream commit 180314e independently corrected the same create_state() exception contract, so this PR is now superseded. Closing to avoid duplicating the fix.

@1cbyc 1cbyc closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StateManager.create_state documents StateDataError for backend failures it never wraps

1 participant