feat(api): standardize pagination and list response structures#70
Merged
feat(api): standardize pagination and list response structures#70
Conversation
- Extracted common `offset` and `limit` query parameter parsing into a centralized `httputil.ParsePagination` helper function for consistency. - Applied the new pagination utility across all listing handlers (`auth`, `tokenization`, and `transit` domains). - Refactored list response DTOs (e.g., `ListClientsResponse`, `ListAuditLogsResponse`, `ListTokenizationKeysResponse`) to utilize a unified `Data` array field, replacing domain-specific names (`Clients`, `AuditLogs`, `Items`). - Updated the CLI application name from `app` to `secrets` in cmd/app/main.go along with a more descriptive usage string. - Bumped project version to `v0.17.0` in cmd/app/main.go, `CHANGELOG.md`, `RELEASES.md`, and `compatibility-matrix.md`. - Updated project documentation (`README.md`, `docs/`, `openapi.yaml`) and integration tests to reflect the new `Data` payload structure and updated CLI metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
offsetandlimitquery parameter parsing into a centralizedhttputil.ParsePaginationhelper function for consistency.auth,tokenization, andtransitdomains).ListClientsResponse,ListAuditLogsResponse,ListTokenizationKeysResponse) to utilize a unifiedDataarray field, replacing domain-specific names (Clients,AuditLogs,Items).apptosecretsin cmd/app/main.go along with a more descriptive usage string.v0.17.0in cmd/app/main.go,CHANGELOG.md,RELEASES.md, andcompatibility-matrix.md.README.md,docs/,openapi.yaml) and integration tests to reflect the newDatapayload structure and updated CLI metadata.