Skip to content

fix output_conf/conf_extra resolutions #41

Merged
allixender merged 3 commits into
allixender:masterfrom
crim-ca:fix-backport-output-conf
Nov 5, 2025
Merged

fix output_conf/conf_extra resolutions #41
allixender merged 3 commits into
allixender:masterfrom
crim-ca:fix-backport-output-conf

Conversation

@fmigneault
Copy link
Copy Markdown
Contributor

@fmigneault fmigneault commented Oct 30, 2025

Changes

  • fix output_conf/conf_extra resolutions
  • fix chaining of DGGRS params across DGGRID calls (eg: vert0 attributes were applied only on the first call)
  • fix cells_for_geo_points attributes override
    • As provided in cells_for_geo_points failed! #39 example, the name attribute of input points was overridden by the DGGRID grid-gen result.
    • Also, the geometry was incorrectly excluded, leading to the points to chain as is to the output.
      To fix this, I rename the column to zone, assuming this is less common than name, and that it shouldn't exist in the input since the zone are being generated by the call.
      Scripts calling this operation will have to consider this column rename.
  • add end-to-end test of cells_for_geo_points and validate each of its intermediate DGGRID metafiles explicitly
  • add dgapi_pres_binning additional arguments that were not considered

Fixes

FYI @allixender @tik65536 @thangqd

@allixender allixender merged commit e03782c into allixender:master Nov 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review on the structure of dictionaries that hold the configuration parameters of DGGRID's meta file cells_for_geo_points failed!

2 participants