Skip to content

fix: various small typos and tweaks - #914

Open
spooktheducks wants to merge 2 commits into
devfrom
spook/external-contributions
Open

fix: various small typos and tweaks#914
spooktheducks wants to merge 2 commits into
devfrom
spook/external-contributions

Conversation

@spooktheducks

Copy link
Copy Markdown
Contributor

Various small typos and tweaks

@github-actions

github-actions Bot commented Feb 18, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedFeb 19, 2026, 11:56 AM

@greptile-apps

greptile-apps Bot commented Feb 18, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes various typos, improves grammar, and makes small quality improvements across documentation, comments, and code. Key improvements include correcting error messages to reference the correct variables, fixing duplicate words in comments, standardizing error message terminology, and improving shell script safety with proper quoting. One issue was introduced: a duplicate thelper linter entry in .golangci.yml.

  • Fixed typo "readyness" → "readiness" across multiple Dockerfiles
  • Corrected error message in app/keepers/keepers.go to reference denom parameter instead of coin.Denom
  • Fixed error messages in x/emissions/keeper/whitelist.go from "admin id" to "actor id" for consistency
  • Improved utils/files.go by replacing errors.New(fmt.Sprintf(...)) with fmt.Errorf(...)
  • Enhanced Dockerfile.upgrade git stash command to check for uncommitted changes first
  • Added --tags flag to git describe in Makefile for better version detection
  • Made README badges clickable and fixed Go Report Card URL
  • Introduced duplicate thelper entry in .golangci.yml (line 31 and 33)

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk after fixing the duplicate linter entry
  • The changes are primarily typo fixes and small quality improvements with positive impact. One syntax error (duplicate linter entry) prevents a perfect score but is easily fixed
  • .golangci.yml needs the duplicate thelper entry removed before merge

Important Files Changed

Filename Overview
.golangci.yml Removed duplicate linters and cleaned up configuration, but introduced duplicate thelper entry on lines 31 and 33
Dockerfile.upgrade Fixed typo "readyness" to "readiness" and improved git stash command to check for uncommitted changes first
app/keepers/keepers.go Fixed error message to reference correct variable denom instead of coin.Denom
utils/files.go Replaced errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) and removed unused import
x/emissions/keeper/whitelist.go Fixed incorrect error messages from "admin id" to "actor id" for consistency

Last reviewed commit: 73b48f3

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread .golangci.yml
Comment thread test/fuzz/fuzz_test.go
// for every iteration
// pick a state transition to try
// check that that state transition even makes sense based on what we know
// check that state transition even makes sense based on what we know

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// check that state transition even makes sense based on what we know
// ensure the selected state transition makes sense based on what we know

@xmariachi xmariachi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a README fix + one suggestion

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 23 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Dockerfile.upgrade">

<violation number="1" location="Dockerfile.upgrade:14">
P2: Condition `git diff-index --quiet HEAD` doesn't detect untracked files, but `git stash -u` is meant to stash them too. If only untracked files exist, the stash will be skipped. Use `git status --porcelain` which covers both tracked changes and untracked files, matching the scope of `git stash -u`.</violation>
</file>

Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread Dockerfile.upgrade

# Save the uncommited changes
RUN git stash -u -m "$GIT_STASH_MESSAGE"
RUN git diff-index --quiet HEAD || git stash -u -m "$GIT_STASH_MESSAGE"

@cubic-dev-ai cubic-dev-ai Bot Feb 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Condition git diff-index --quiet HEAD doesn't detect untracked files, but git stash -u is meant to stash them too. If only untracked files exist, the stash will be skipped. Use git status --porcelain which covers both tracked changes and untracked files, matching the scope of git stash -u.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Dockerfile.upgrade, line 14:

<comment>Condition `git diff-index --quiet HEAD` doesn't detect untracked files, but `git stash -u` is meant to stash them too. If only untracked files exist, the stash will be skipped. Use `git status --porcelain` which covers both tracked changes and untracked files, matching the scope of `git stash -u`.</comment>

<file context>
@@ -11,7 +11,7 @@ ADD . /src
 
 # Save the uncommited changes
-RUN git stash -u -m "$GIT_STASH_MESSAGE"
+RUN git diff-index --quiet HEAD || git stash -u -m "$GIT_STASH_MESSAGE"
 # Switch to the baseline version
 RUN git checkout $BASELINE_VERSION_TAG
</file context>
Suggested change
RUN git diff-index --quiet HEAD || git stash -u -m "$GIT_STASH_MESSAGE"
RUN test -z "$(git status --porcelain)" || git stash -u -m "$GIT_STASH_MESSAGE"
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants