fix: various small typos and tweaks - #914
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).
|
Greptile SummaryThis PR fixes various typos, improves grammar, and makes small quality improvements across documentation, comments, and code. Key improvements include correcting error messages to reference the correct variables, fixing duplicate words in comments, standardizing error message terminology, and improving shell script safety with proper quoting. One issue was introduced: a duplicate
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| .golangci.yml | Removed duplicate linters and cleaned up configuration, but introduced duplicate thelper entry on lines 31 and 33 |
| Dockerfile.upgrade | Fixed typo "readyness" to "readiness" and improved git stash command to check for uncommitted changes first |
| app/keepers/keepers.go | Fixed error message to reference correct variable denom instead of coin.Denom |
| utils/files.go | Replaced errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) and removed unused import |
| x/emissions/keeper/whitelist.go | Fixed incorrect error messages from "admin id" to "actor id" for consistency |
Last reviewed commit: 73b48f3
73b48f3 to
ba822c9
Compare
| // for every iteration | ||
| // pick a state transition to try | ||
| // check that that state transition even makes sense based on what we know | ||
| // check that state transition even makes sense based on what we know |
There was a problem hiding this comment.
| // check that state transition even makes sense based on what we know | |
| // ensure the selected state transition makes sense based on what we know |
xmariachi
left a comment
There was a problem hiding this comment.
Pushed a README fix + one suggestion
There was a problem hiding this comment.
1 issue found across 23 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Dockerfile.upgrade">
<violation number="1" location="Dockerfile.upgrade:14">
P2: Condition `git diff-index --quiet HEAD` doesn't detect untracked files, but `git stash -u` is meant to stash them too. If only untracked files exist, the stash will be skipped. Use `git status --porcelain` which covers both tracked changes and untracked files, matching the scope of `git stash -u`.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| # Save the uncommited changes | ||
| RUN git stash -u -m "$GIT_STASH_MESSAGE" | ||
| RUN git diff-index --quiet HEAD || git stash -u -m "$GIT_STASH_MESSAGE" |
There was a problem hiding this comment.
P2: Condition git diff-index --quiet HEAD doesn't detect untracked files, but git stash -u is meant to stash them too. If only untracked files exist, the stash will be skipped. Use git status --porcelain which covers both tracked changes and untracked files, matching the scope of git stash -u.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Dockerfile.upgrade, line 14:
<comment>Condition `git diff-index --quiet HEAD` doesn't detect untracked files, but `git stash -u` is meant to stash them too. If only untracked files exist, the stash will be skipped. Use `git status --porcelain` which covers both tracked changes and untracked files, matching the scope of `git stash -u`.</comment>
<file context>
@@ -11,7 +11,7 @@ ADD . /src
# Save the uncommited changes
-RUN git stash -u -m "$GIT_STASH_MESSAGE"
+RUN git diff-index --quiet HEAD || git stash -u -m "$GIT_STASH_MESSAGE"
# Switch to the baseline version
RUN git checkout $BASELINE_VERSION_TAG
</file context>
| RUN git diff-index --quiet HEAD || git stash -u -m "$GIT_STASH_MESSAGE" | |
| RUN test -z "$(git status --porcelain)" || git stash -u -m "$GIT_STASH_MESSAGE" |
Various small typos and tweaks