fix: correct swapped error log messages in payload events - #917
Open
VolodymyrBg wants to merge 1 commit into
Open
fix: correct swapped error log messages in payload events#917VolodymyrBg wants to merge 1 commit into
VolodymyrBg wants to merge 1 commit into
Conversation
Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
VolodymyrBg
requested review from
spooktheducks,
xmariachi and
zale144
as code owners
February 22, 2026 20:28
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Error log messages in
EmitNewInsertInfererPayloadEventandEmitNewInsertForecasterPayloadEventwere swapped — each function was logging the other's event name, making debugging confusing.Fixed the log messages to correctly identify which event failed to emit.
Link(s) to Ticket(s) or Issue(s) resolved by this PR
None
Are these changes tested and documented?
Summary by cubic
Fixed swapped error log messages in EmitNewInsertInfererPayloadEvent and EmitNewInsertForecasterPayloadEvent so failures log the correct event name, improving debugging clarity.
Written for commit 5e23f84. Summary will update on new commits.