Skip to content

fix: force using simulated gas estimation - #142

Merged
amimart merged 8 commits into
devfrom
arnaud/engn-4468-use-simulated-gas
Dec 10, 2025
Merged

fix: force using simulated gas estimation#142
amimart merged 8 commits into
devfrom
arnaud/engn-4468-use-simulated-gas

Conversation

@amimart

@amimart amimart commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Purpose of Changes and their Description

Enforces the usage of estimated gas during tx simulation, the tx simulation is now systematic for that purpose and gas configuration related to the old behaviour has been removed (config files containing old fields won't cause any trouble).

This has been tested locally, with situations causing account sequence mismatches to ensure reliability over it.

Misc

  • The tx is now signed only after simulation, as it is not required for it;

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed.
  • If documented, please describe where. If not, describe why docs are not needed.
  • Added to Unreleased section of CHANGELOG.md?

@amimart amimart changed the title Arnaud/engn 4468 use simulated gas fix: force using simulated gas estimation Dec 4, 2025
@amimart
amimart marked this pull request as ready for review December 8, 2025 15:11

@xmariachi xmariachi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a comment

Comment thread gas_and_fees.md
@amimart
amimart merged commit 5d4b783 into dev Dec 10, 2025
9 checks passed
@amimart
amimart deleted the arnaud/engn-4468-use-simulated-gas branch December 10, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants