Repository navigation
Fix borderless outline link-buttons and keep Audit inside Administration - #66
Merged
Merged
Conversation
buttonVariants() returned a raw cva string, so links styled as outline buttons kept border-transparent alongside the variant border colour and rendered as plain text. Merge the classes with cn. Render the organization audit trail at /admin/audit so the Administration tabs stay visible, send administrators from /audit there, drop the redundant Back to tasks on Find tasks, and make Disable on a team look like a button. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lu73uozkZGX8gP8LWNbBqt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Two UI problems reported after #64:
buttonVariants()returned a rawcvastring. A link styled as an outline button (<Link className={buttonVariants({ variant: "outline" })}>) therefore kept both the baseborder-transparentand the variant'sborder-border-strong, and the transparent one won (confirmed in the browser: computed border colour was transparent). TheButtoncomponent was unaffected because it merges withcn.buttonVariantsnow merges too, which fixes every link-styled button in the app, not only the new pages ("Back to tasks", Export CSV, Add agent on Home, and so on)./audit, outside the Administration layout, so the tabs disappeared with no way back. The organization audit trail now renders at/admin/auditinside the layout (AuditViewextracted tocomponents/audit/audit-view.tsx)./auditsends administrators there;/audit?taskId=…remains a single task's trail with its Back to task button. The shell no longer highlights Administration on/audit.Also: removed the redundant Back to tasks button from Find tasks (a top-level page), and Disable on a team is now an outline button instead of text-like ghost.
How it was verified
border-top-colorof the "Back to tasks" link was transparent; after the fix it is a visible grey./auditas an administrator lands on/admin/audit, the Administration tabs stay visible, and People is one click away.src/components/ui/button.test.ts(variant border replaces the transparent base, caller classes win) and the updated admin tab list test.npm run lint,tsc --noEmit, all 597 unit tests andnpm run buildpass.Not verified: I did not rerun the database and HTTP suites, since this only changes UI components, and CI will. I did not check every older page that uses a link-styled button, in dark mode, after the border fix; an automated pass over all pages was started and stopped before it ran. Safari and Firefox were not checked; only Chromium is available in my environment.
Checklist
npm run checkpasses (or the part you could run is listed above) — only the UI-relevant part was run; see abovedocs/contributing/documentation.md(or say why none apply)docs/security/threat-model.md(not applicable: no change to access control)CHANGELOG.mdGenerated by Claude Code