Skip to content

Fix borderless outline link-buttons and keep Audit inside Administration - #66

Merged
shashikanth-gs merged 1 commit into
mainfrom
claude/ui-polish
Oct 19, 2026
Merged

shashikanth-gs merged 1 commit into
mainfrom
claude/ui-polish

Conversation

@shashikanth-gs

Copy link
Copy Markdown
Member

What changed and why

Two UI problems reported after #64:

  • Buttons that looked like plain text. buttonVariants() returned a raw cva string. A link styled as an outline button (<Link className={buttonVariants({ variant: "outline" })}>) therefore kept both the base border-transparent and the variant's border-border-strong, and the transparent one won (confirmed in the browser: computed border colour was transparent). The Button component was unaffected because it merges with cn. buttonVariants now merges too, which fixes every link-styled button in the app, not only the new pages ("Back to tasks", Export CSV, Add agent on Home, and so on).
  • Audit trail dropped you out of Administration. The tab linked to /audit, outside the Administration layout, so the tabs disappeared with no way back. The organization audit trail now renders at /admin/audit inside the layout (AuditView extracted to components/audit/audit-view.tsx). /audit sends administrators there; /audit?taskId=… remains a single task's trail with its Back to task button. The shell no longer highlights Administration on /audit.

Also: removed the redundant Back to tasks button from Find tasks (a top-level page), and Disable on a team is now an outline button instead of text-like ghost.

How it was verified

  • Reproduced the bug first: computed border-top-color of the "Back to tasks" link was transparent; after the fix it is a visible grey.
  • Clicked through in a browser: /audit as an administrator lands on /admin/audit, the Administration tabs stay visible, and People is one click away.
  • Screenshotted all new pages in light, dark and phone width, plus Home after the change.
  • New tests: src/components/ui/button.test.ts (variant border replaces the transparent base, caller classes win) and the updated admin tab list test.
  • npm run lint, tsc --noEmit, all 597 unit tests and npm run build pass.

Not verified: I did not rerun the database and HTTP suites, since this only changes UI components, and CI will. I did not check every older page that uses a link-styled button, in dark mode, after the border fix; an automated pass over all pages was started and stopped before it ran. Safari and Firefox were not checked; only Chromium is available in my environment.

Checklist

  • Focused change, with tests in the same change
  • npm run check passes (or the part you could run is listed above) — only the UI-relevant part was run; see above
  • Docs updated for the behavior you changed, per docs/contributing/documentation.md (or say why none apply)
  • Security-relevant changes update docs/security/threat-model.md (not applicable: no change to access control)
  • User-visible changes are in CHANGELOG.md

Generated by Claude Code

buttonVariants() returned a raw cva string, so links styled as outline buttons kept
border-transparent alongside the variant border colour and rendered as plain text.
Merge the classes with cn. Render the organization audit trail at /admin/audit so the
Administration tabs stay visible, send administrators from /audit there, drop the
redundant Back to tasks on Find tasks, and make Disable on a team look like a button.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lu73uozkZGX8gP8LWNbBqt
@shashikanth-gs
shashikanth-gs merged commit e056d8b into main Oct 19, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants