Skip to content

fix(web): preserve archived forum access and viewer permissions - #865

Merged
GenerQAQ merged 2 commits into
mainfrom
fix/forum-archive-access-samara
Oct 4, 2026
Merged

GenerQAQ merged 2 commits into
mainfrom
fix/forum-archive-access-samara

Conversation

@GenerQAQ

@GenerQAQ GenerQAQ commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Why we need this PR?

Archived forum tags could incorrectly mark a channel inaccessible and purge its cached post. Management controls also waited for the viewer to appear in a paginated member roster.

What changed

  • Separate post archive tags from qualified channel archive metadata.
  • Resolve the current viewer's role independently of the roster; retire stale permissions on account/access changes.
  • Cover archive recovery, member-ID demotion and genuine denied/deleted channel exits.

Validation

Normal repository checks and exact-head Hosted CI pass; changed-line coverage is 35/35.

Independent archive/admin/member journeys and four final child-readiness journeys passed. The original22 batch retains four input timeouts; repeated attempts remain separate in the QA evidence.

Current integration with #864, same-context account switching, restored unknown-role authorization, actual channel archive-bit exit and native QA remain unfinished. Merged at the owner's request within the delivered archive/access scope; unfinished checks remain unclaimed.

Checklist

  • Tests added/updated as needed
  • All CI checks pass
  • Browser/integration runtime acceptance complete
  • PR targets the correct branch

Impact Areas

  • Shared library (@alook/shared)
  • Web app (@alook/web)
  • App (@alook/app)
  • Email Worker (@alook/email-worker)
  • WebSocket DO (@alook/ws-do)
  • CI/CD
  • Other

@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

GenerQAQ added a commit that referenced this pull request Oct 4, 2026
Merge the frozen fb560f4 revision after the owner explicitly accepted known browser failures.

Normal checks and exact-head CI pass. Owner original 3: 2 passed, 1 failed (rapid-grow-two tail distance 142px against 1px). Independent regression stopped at owner request; recorded failures remain retained. Browser acceptance, integration with #865, account/access edge cases, native QA and complete Hosted artifact review remain incomplete.
@GenerQAQ
GenerQAQ marked this pull request as ready for review October 4, 2026 13:42
@GenerQAQ
GenerQAQ merged commit 6d42bf9 into main Oct 4, 2026
28 checks passed
@GenerQAQ
GenerQAQ deleted the fix/forum-archive-access-samara branch October 4, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant