STR-3155: bind snark account updates to specific seqnos

[delbonis]

Description

This PR fixes an audit finding by adding a seq_no field to the snark account update proof interface, binding the proofs to a specific update seqno.

Claude did most of the low-level work with me guiding it to minimize change blast radius.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactor
• New or updated tests
• Dependency Update

Notes to Reviewers

Is this PR addressing any specification, design doc or external reference document?

• Yes
• No

If yes, please add relevant links:

Checklist

• I have performed a self-review of my code.
• I have commented my code where necessary.
• I have updated the documentation if needed.
• My changes do not introduce new warnings.
• I have added (where necessary) tests that prove my changes are effective or that my feature works.
• New and existing tests pass with my changes.
• I have disclosed my use of AI in the body of this PR.

Related Issues

[github-actions]

Commit: a499232

SP1 Execution Results

program	cycles	gas
EVM EE Chunk	565,596	771,682
EVM EE Account	421,839	527,631
Checkpoint	2,241,398	2,582,981

[codecov]

Codecov Report

❌ Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.74%. Comparing base (71d03a2) to head (c5e3bef).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
bin/alpen-client/src/prover/spec_acct.rs	0.00%	3 Missing ⚠️
crates/snark-acct-types/src/proof_interface.rs	88.46%	3 Missing ⚠️

@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
+ Coverage   79.63%   79.74%   +0.10%     
==========================================
  Files         666      674       +8     
  Lines       73278    74745    +1467     
==========================================
+ Hits        58356    59605    +1249     
- Misses      14922    15140     +218     

Flag	Coverage Δ
functional	60.16% <46.15%> (+0.37%)	⬆️
unit	65.64% <83.78%> (-0.24%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
bin/prover-perf/src/programs/alpen_acct.rs	89.55% <100.00%> (+0.15%)	⬆️
bin/strata-test-cli/src/mock_ee/withdrawal.rs	100.00% <100.00%> (ø)
crates/proof-impl/alpen-acct/src/program.rs	96.62% <100.00%> (+0.03%)	⬆️
crates/snark-acct-runtime/src/update_builder.rs	73.41% <100.00%> (+0.11%)	⬆️
crates/snark-acct-sys/src/verification.rs	99.18% <100.00%> (+<0.01%)	⬆️
bin/alpen-client/src/prover/spec_acct.rs	51.63% <0.00%> (-1.04%)	⬇️
crates/snark-acct-types/src/proof_interface.rs	98.02% <88.46%> (-1.98%)	⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bewakes]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[bewakes]

Looks good, but tests are failing.

[storopoli]

ACK a3d8e5b

Great that you've added a regression test! :)

[delbonis]

Verrryyyy weird panic in recent versions of bitreq. Disabling a debug assertions for that crate.

See: rust-bitcoin/corepc#584

[storopoli]

ACK ce1a8af

1 minor non-blocking nit.

[storopoli]

add a TODO(STR-XXXX) comment here.

[delbonis]

Created ticket: https://alpenlabs.atlassian.net/browse/STR-3554

[storopoli]

ACK c5e3bef