Skip to content

doc(ol,asm): OL/ASM withdrawal/deposits/assignments logs#1852

Open
storopoli wants to merge 2 commits into
mainfrom
OL-ASM-logs
Open

doc(ol,asm): OL/ASM withdrawal/deposits/assignments logs#1852
storopoli wants to merge 2 commits into
mainfrom
OL-ASM-logs

Conversation

@storopoli
Copy link
Copy Markdown
Member

Description

More ASM/OL logs on deposit/withdrawals.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update
  • Logs

Notes to Reviewers

Sister PR to alpenlabs/asm#110

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Related Issues

STR-1405 and STR-3557

@github-actions
Copy link
Copy Markdown
Contributor

Commit: dc9aed2

SP1 Execution Results

program cycles gas
EVM EE Chunk 565,505 771,876
EVM EE Account 421,125 526,509
Checkpoint 2,241,648 2,583,167

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.99%. Comparing base (6b27610) to head (3c8694f).

Files with missing lines Patch % Lines
crates/alpen-ee/block-assembly/src/package.rs 57.14% 3 Missing ⚠️
crates/alpen-ee/block-assembly/src/payload.rs 50.00% 2 Missing ⚠️
@@           Coverage Diff           @@
##             main    #1852   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files         674      674           
  Lines       75685    75696   +11     
=======================================
+ Hits        60547    60556    +9     
- Misses      15138    15140    +2     
Flag Coverage Δ
functional 60.19% <72.72%> (+<0.01%) ⬆️
unit 66.11% <63.63%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
bin/alpen-client/src/payload_builder.rs 90.00% <ø> (ø)
crates/ol/stf/src/account_processing.rs 99.00% <100.00%> (+0.04%) ⬆️
crates/ol/stf/src/manifest_processing.rs 94.11% <100.00%> (+0.03%) ⬆️
crates/alpen-ee/block-assembly/src/payload.rs 97.53% <50.00%> (-2.47%) ⬇️
crates/alpen-ee/block-assembly/src/package.rs 91.81% <57.14%> (-2.63%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli changed the title OL-ASM-logs doc(ol,asm): OL/ASM withdrawal/deposits/assignments logs May 22, 2026
Copy link
Copy Markdown
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if any of these could be lowered to debug/trace, but looks good otherwise.

Copy link
Copy Markdown
Contributor

@barakshani barakshani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@voidash is this the right place to add some "observability" aspects? I'm sure that at some point we'd like to track all minted funds and withdrawals.

Comment on lines +79 to +86
for (deposit_index, withdrawal) in withdrawals.iter().enumerate() {
info!(
%parent,
deposit_index,
address = %withdrawal.address,
amount_gwei = withdrawal.amount,
"prepared deposit mint for payload attributes",
);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this withdrawals is Eth beacon chain withdrawals, so our deposits. If so, why withdrawal.address and not deposit.address (i.e. withdrawal --> deposit). Also curious, where do we get deposit_index at this stage? Is this necessarily the same deposit_index as in the bridge, or internal to reth? (or is it just 'local' indexing within this block?)
On the latter, just in case, see https://alpenlabs.atlassian.net/browse/STR-3567: the report says that the issue is in the RPC, but maybe it's deeper than that. (maybe we have some indexing issue at this level)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants