doc(ol,asm): OL/ASM withdrawal/deposits/assignments logs#1852
doc(ol,asm): OL/ASM withdrawal/deposits/assignments logs#1852storopoli wants to merge 2 commits into
Conversation
|
Commit: dc9aed2 SP1 Execution Results
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1852 +/- ##
=======================================
Coverage 79.99% 79.99%
=======================================
Files 674 674
Lines 75685 75696 +11
=======================================
+ Hits 60547 60556 +9
- Misses 15138 15140 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
delbonis
left a comment
There was a problem hiding this comment.
Wondering if any of these could be lowered to debug/trace, but looks good otherwise.
barakshani
left a comment
There was a problem hiding this comment.
Perfect, thanks!
@voidash is this the right place to add some "observability" aspects? I'm sure that at some point we'd like to track all minted funds and withdrawals.
| for (deposit_index, withdrawal) in withdrawals.iter().enumerate() { | ||
| info!( | ||
| %parent, | ||
| deposit_index, | ||
| address = %withdrawal.address, | ||
| amount_gwei = withdrawal.amount, | ||
| "prepared deposit mint for payload attributes", | ||
| ); |
There was a problem hiding this comment.
I assume this withdrawals is Eth beacon chain withdrawals, so our deposits. If so, why withdrawal.address and not deposit.address (i.e. withdrawal --> deposit). Also curious, where do we get deposit_index at this stage? Is this necessarily the same deposit_index as in the bridge, or internal to reth? (or is it just 'local' indexing within this block?)
On the latter, just in case, see https://alpenlabs.atlassian.net/browse/STR-3567: the report says that the issue is in the RPC, but maybe it's deeper than that. (maybe we have some indexing issue at this level)
Description
More ASM/OL logs on deposit/withdrawals.
Type of Change
Notes to Reviewers
Sister PR to alpenlabs/asm#110
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues
STR-1405 and STR-3557