test(storage): drop redundant persistence-across-reopen tests#107
Merged
Conversation
These exercised sled's own file-lock and durability across reopen, which sled already covers. They were also flaky on Linux due to a sled 0.34 race on tempdir cleanup — papered over in the test body with explicit `drop` and `flush` calls. End-to-end persistence is now covered at the level we actually care about (runner reload across stop/start) by the new asm-runner restart test, so these unit tests carry their flakiness for no incremental coverage.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
MdTeach
approved these changes
May 19, 2026
|
Commit: ebe7675
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two
persistence_across_reopenunit tests incrates/storage(inexport_entries.rsandmmr.rs) were flaky on Linux due to a sled 0.34 tempdir-lock race on reopen, causing failures in the CI. They duplicated coverage that sled itself provides for its KV layer, and were proxying for end-to-end behavior — runner state surviving stop/start — which felt more like a functional test for restart.#105 was originally opened to fix the flake but the PR's scope shifted to other work (a flexitest that actually covers stop/start + runner-restart catch-up). This PR carries just the test deletions so they can land independently.
Type of Change
Notes to Reviewers
Pure deletion.
Checklist
Related Issues