fix(functional-tests): avoid unbound CARGO_ARGS under set -u#109
Merged
Conversation
`run_test.sh` runs with `set -u`. Expanding `"${CARGO_ARGS[@]}"` for an
empty array triggers "unbound variable" on bash 3.2 (the default shell
on macOS), so the native backend path failed before invoking cargo. Use
the `${arr[@]+"${arr[@]}"}` idiom to expand only when the array is set.
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
Commit: 4cee9e2
|
MdTeach
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
functional-tests/run_test.shruns underset -u. For thenativebackend,CARGO_ARGS=()is an empty array, and on bash 3.2 (still the default/bin/bashon macOS) expanding"${CARGO_ARGS[@]}"underset -uerrors out withunbound variable, so the script aborts before invokingcargo build.Switched the expansion to the standard
${CARGO_ARGS[@]+"${CARGO_ARGS[@]}"}idiom, which expands only when the array is set. No behavior change on bash 4+/5+ or for thesp1backend.Type of Change
Notes to Reviewers
Single-line shell change. Reproducible on macOS by running
./run_test.shwith the defaultASM_PROVER_BACKEND=native.Checklist
Related Issues
N/A