fix(session-recap): avoid stale ctx.hasUI calls after session replacement#1
Open
alpertarhan wants to merge 1 commit into
Open
fix(session-recap): avoid stale ctx.hasUI calls after session replacement#1alpertarhan wants to merge 1 commit into
alpertarhan wants to merge 1 commit into
Conversation
…ment Avoid calling ctx.hasUI on contexts that may be stale after session replacement (reload, fork, switchSession). Instead, track uiActive state in the extension and only use ctx.hasUI in session_start where the context is guaranteed fresh. This fixes the error: This extension ctx is stale after session replacement or reload. Do not use a captured pi or command ctx after ctx.newSession(), ctx.fork(), ctx.switchSession(), or ctx.reload(). Fixes: pi-mono/issues#3021
alpertarhan
force-pushed
the
fix/stale-context-after-session-replacement
branch
from
8d94698 to
eeeeff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pi-mono issue #3021 where session-recap crashes with stale ctx error after session replacement commands like /reload.