Fix provenance handling for secondary files#1068
Draft
GlassOfWhiskey wants to merge 1 commit into
Draft
Conversation
Add a `Collection` case to the `property_values` match block in `CWLRunCrateProvenanceManager` so that Collection-typed secondary files are tracked by `@id` in provenance graphs instead of being incorrectly treated as primitive values.
GlassOfWhiskey
force-pushed
the
fix-secondary-files-provenance
branch
from
6b30c91 to
0465098
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
- Coverage 64.16% 62.63% -1.53%
==========================================
Files 93 89 -4
Lines 17510 12373 -5137
Branches 2149 2150 +1
==========================================
- Hits 11235 7750 -3485
+ Misses 5997 4011 -1986
- Partials 278 612 +334 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
Collectioncase to theproperty_valuesmatch block inCWLRunCrateProvenanceManagerso that Collection-typed secondary files are tracked by@idin provenance graphs instead of being incorrectly treated as primitive values.