Skip to content

Fix provenance of empty unbound inputs#968

Merged
GlassOfWhiskey merged 4 commits into
masterfrom
save-empty-unbound-in
May 20, 2026
Merged

Fix provenance of empty unbound inputs#968
GlassOfWhiskey merged 4 commits into
masterfrom
save-empty-unbound-in

Conversation

@LanderOtto
Copy link
Copy Markdown
Collaborator

@LanderOtto LanderOtto commented Feb 26, 2026

This commit resolves an issue where None tokens of unbound input ports lacked a persistent id, leading to invalid entries in the provenance database.

The commit introduces an InputInjectorStep to persist None tokens and adds a new step, BroadcastTransformer, to distribute a single token across multiple output ports.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.18%. Comparing base (8d26783) to head (443fbf4).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
streamflow/workflow/transformer.py 55.55% 2 Missing and 2 partials ⚠️
streamflow/workflow/step.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
+ Coverage   64.16%   64.18%   +0.02%     
==========================================
  Files          93       93              
  Lines       17510    17534      +24     
  Branches     2149     2155       +6     
==========================================
+ Hits        11235    11254      +19     
- Misses       5997     6000       +3     
- Partials      278      280       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread streamflow/cwl/translator.py Outdated
…kens lacked persistent id, leading to invalid entries in the provenance database.

The commit introduces an `InputInjectorStep` to persist `None` tokens and adds a new step, `BroadcastTransformer`, to handle distributing a single token across multiple output ports.
@LanderOtto LanderOtto force-pushed the save-empty-unbound-in branch from 79974a9 to 5a85607 Compare May 20, 2026 08:55
@LanderOtto LanderOtto force-pushed the save-empty-unbound-in branch from 5a85607 to 443fbf4 Compare May 20, 2026 09:01
Copy link
Copy Markdown
Member

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlassOfWhiskey GlassOfWhiskey merged commit 3fa66bb into master May 20, 2026
64 of 83 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the save-empty-unbound-in branch May 20, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants