Skip to content

fix: tell a chat once when a run's metrics are cut short - #1147

Merged
small-angel merged 1 commit into
mainfrom
clo/lost-rental-notices
Nov 20, 2026
Merged

small-angel merged 1 commit into
mainfrom
clo/lost-rental-notices

Conversation

@small-angel

Copy link
Copy Markdown
Contributor

When a rental went away before its final log was kept, the chat's agent got two turns for it: the result notice already said why collection stopped, and then a second "signal collection could not finish" notice said it again. The follow-up now goes out only when the result the chat accepted didn't carry the cause (it was delivered before collection settled), including across a restart. The run page also says it couldn't finish reading the run's metrics and keeps the last readings, instead of "No metrics were found in this run's log."

Found running hand tests 60 and 61 live on orx compute rentals.

Before After
Run page before Run page after

Assisted-by: gpt-6.2-sol
Assisted-by: claude-opus-5.5

Include the collection cause and saved-output guidance in the result
turn when possible. Use each chat’s accepted prompt to avoid repeating
the failure after collection settles or the app restarts.

Show incomplete final collection on the run page alongside the last
readings, without claiming the log contained no metrics.

Assisted-by: gpt-6.2-sol
Assisted-by: claude-opus-5.5
@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The PR avoids repeating a collection failure when a chat’s accepted result already included the same cause and saved-output guidance.

  • Chats get the collection cause once, in the result or a follow-up.
  • Ended runs explain incomplete metric reading and keep saved progress visible.

No actionable issues found. Tests and the app were not run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Collection ends incomplete] --> B[Queue notice for each chat]
  B --> C{Accepted result includes the same cause and guidance?}
  C -->|Yes, and follow-up not admitted| D[Mark notice delivered without another turn]
  C -->|No| E[Send follow-up]
  A --> F[Mark ended run's monitor incomplete]
  F --> G[Show notice and keep saved readings]
Loading

Reviews (1) · Last reviewed commit: "fix: report incomplete run signal collec..." · Reviewed by Greptile

@small-angel
small-angel merged commit 505da3b into main Nov 20, 2026
28 checks passed
@small-angel
small-angel deleted the clo/lost-rental-notices branch November 20, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant