Repository navigation
fix: end run Setup at a bare count - #1148
Merged
Merged
Conversation
Treat an explicit step as the start of work even without a stage name. Remember the count when its stage ages out of the checkpoint so the dashboard, status command and watcher share the same Setup boundary. Assisted-by: gpt-6.2-sol Assisted-by: claude-opus-5.5
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryBare declared step counts now end Setup through the shared monitor.
Review was based on source inspection. Tests and visual checks were not run. Reviews (1) · Last reviewed commit: "fix: end run Setup at a bare count" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run that only prints a bare counter like
::orx:: {"step":10,"of":100}(no named stage, no charted metric) stayed in "Setup · Step 10 of 100" for its whole life. The first bare count now ends Setup on the run line, card, run page,orx exp statusand the watcher, the same way a named stage's count does since #1123.Assisted-by: gpt-6.2-sol
Assisted-by: claude-opus-5.5