Repository navigation
fix: steady sidebar title spacing on title reveal - #1149
Merged
Merged
Conversation
The reveal wraps the title in a block with overflow hidden, which moves the inline-block wrapper's baseline to its bottom edge and grows the title line by ~5px while a generated title animates in. Assisted-by: claude-opus-5.5
Contributor
[Low impact] The PR appears safe to merge. SummaryAdds
Reviews (1) · Last reviewed commit: "fix: steady sidebar title spacing on tit..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a generated title animated into a sidebar card, the title and subline drifted apart by ~5px and snapped back when the sweep ended.
.title-revealis a block withoverflow: hiddeninside the title'sinline-blockwrapper, which drops the wrapper's baseline to its bottom edge and adds descender room to the line. The wrappers are nowalign-top;overflow: clipwould only have fixed Chromium.Measured on the dashboard in Playwright Chromium and WebKit: the title line stays 20px during a reveal (25px / 24.7px before). Recorded with a real Haiku chat in WebKit, before on top, after below. Not checked in the macOS app window, WebKitGTK or WebView2. Typecheck, style lint and UI tests pass.
Reviewed with sol-loop: 1 round with gpt-6.2-sol. Sol verdict: approved
Assisted-by: claude-opus-5.5