Repository navigation
fix: say each run strip notice once - #1151
small-angel wants to merge 2 commits into
Conversation
[Medium impact] The changes affect run status displays and charts across several run views. Fix grouped parent-marker placement before merging. Findings
Fix with agent prompt### Issue 1
ui/src/components/run/blocks/Chart.tsx:318
When a chart uses `by` with `ghost: "parent"`, the grouped series share the same `x` and `y`. This `findIndex` therefore returns the first series for every parent marker. Later groups lose their parent comparison, while the first group shows unrelated markers. Match each parent series to its own series, including its group.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryThe PR removes repeated notice text and Connect buttons from expanded run strips.
Tests and visual checks were not run; this checkout has no installed UI dependencies. Reviews (1) · Last reviewed commit: "fix: resolve run strip gallery findings" · Reviewed by Greptile |
| const bars = (strip: boolean) => [...owned, ...series.filter((line) => line.ghost)].map((line) => { | ||
| const index = line.ghost ? series.filter((one) => one.ghost).indexOf(line) : owned.indexOf(line); | ||
| const left = (at: number) => x(at) - (slot * 0.7) / 2 + index * barWidth; | ||
| const index = line.ghost ? owned.findIndex((one) => one.x === line.x && one.y === line.y) : owned.indexOf(line); |
There was a problem hiding this comment.
Parent markers show wrong groups
When a chart uses by with ghost: "parent", the grouped series share the same x and y. This findIndex therefore returns the first series for every parent marker. Later groups lose their parent comparison, while the first group shows unrelated markers. Match each parent series to its own series, including its group.
Prompt To Fix With AI
This is a comment left during a code review.
Path: ui/src/components/run/blocks/Chart.tsx
Line: 318
Comment:
**Parent markers show wrong groups**
When a chart uses `by` with `ghost: "parent"`, the grouped series share the same `x` and `y`. This `findIndex` therefore returns the first series for every parent marker. Later groups lose their parent comparison, while the first group shows unrelated markers. Match each parent series to its own series, including its group.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
valid, and it came from matching parent bars by signal in this patch. d16bf59 matches each parent line to its own line by name again, and a new test draws grouped bars with a parent and checks every bar has its parent level over it (it fails on the signal match).
There was a problem hiding this comment.
Thanks for confirming. Matching parent bars by signal conflated grouped series; matching each parent line to its own line by name, with the regression test, addresses the finding.
Keep reporting and contact messages in the strip header, with the retry time in the contact sentence and a single Connect action. The expanded strip adds the cause and recovery actions. The run page presents the full notice once. Bar charts plot observations, so offset one bar per numeric row within its category and series. The readout gives each plotted value. Inset strip plots to fit the full stroke of the step-zero marker. Remove the resolved finding labels from the gallery. Assisted-by: gpt-6.2-sol Assisted-by: claude-opus-5.5
Grouped bars share their signal, so matching a parent's bars by signal put every group's parent level over the first group. Match each parent line to its own line by name again, and test grouped bars against the parent's. Assisted-by: claude-opus-5.5
89af3a7 to
d16bf59
Compare
Fixes the four run strip states #1150's gallery marked as findings. Expanded, the strip no longer repeats the reporting error or the unreachable message and retry time under the header; the header says it once and the body keeps only the cause and the actions. A host that needs authentication offers Connect once, in the header. Bars from repeated categories sit side by side within their category instead of covering each other, and the strip plot is inset enough that the step-zero marker isn't clipped. The gallery's Finding labels for these are gone.
Stacked on #1150.
Assisted-by: gpt-6.2-sol
Assisted-by: claude-opus-5.5