fix: use pathToFileURL for dynamic imports on Windows#12
Open
Jgaleas7 wants to merge 2 commits into
Open
Conversation
On Windows, Node.js ESM requires file:// URLs for dynamic import() calls. Raw absolute paths like C:\... cause ERR_UNSUPPORTED_ESM_URL_SCHEME since Node interprets 'C:' as a URL protocol scheme. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
this was the original solution but dit not worked. Is usseles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file://URLs for dynamicimport()calls. Raw absolute paths likeC:\...causeERR_UNSUPPORTED_ESM_URL_SCHEMEbecause Node interpretsC:as a URL protocol scheme.import()calls withpathToFileURL().hrefinworkspace-controller.jsandpackages/markdown/index.jsmainandexportsfields topackages/markdown/package.jsonto resolve DEP0151 deprecation warningTest plan
npm run devon Windows and verify noERR_UNSUPPORTED_ESM_URL_SCHEMEerrornpm run devon macOS/Linux and verify no regressionsnpm run build && npm start) works on Windows🤖 Generated with Claude Code