Repository navigation
Fix implementation record header - #5662
Merged
Merged
Conversation
AshGDS
reviewed
Sep 10, 2026
AshGDS
left a comment
AshGDS
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just had a question before approving
- was appearing incorrectly styled with light blue text on a dark blue background - fixed by updating the markup - ideally would use the layout component for this rather than hard coding the markup, but we can't render components directly in the tech docs so have to use `GovukPublishingComponents.render`, which doesn't seem to support yielding to blocks, which is what the layout component depends on - as an improvement have also added the service navigation component - unfortunately couldn't call the component here directly either because there's a mystery CSS rule which causes the content to be full width, which misaligns it with the rest of the page which acted on `govuk-width-container` being the immediate child of the component, fix was to insert an extra div to break this layout, so the normal styles can function correctly
andysellick
force-pushed
the
fix-imp-record-header
branch
from
September 10, 2026 11:41
3cbe6d2 to
1337490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/why
GovukPublishingComponents.render, which doesn't seem to support yielding to blocks, which is what the layout component depends ongovuk-width-containerbeing the immediate child of the component, fix was to insert an extra div to break this layout, so the normal styles can function correctlyVisual changes