Add variant parameter to ImageProcessingChecker#11454
Open
patrickpatrickpatrick wants to merge 1 commit into
Open
Add variant parameter to ImageProcessingChecker#11454patrickpatrickpatrick wants to merge 1 commit into
variant parameter to ImageProcessingChecker#11454patrickpatrickpatrick wants to merge 1 commit into
Conversation
patrickpatrickpatrick
force-pushed
the
request-variant-image-processing
branch
2 times, most recently
from
e83656c to
99326a6
Compare
To prevent the incorrect variant of an image being used, you can now specify a `variant` in the `ImageProcessingChecker` so that the correct variant of an image will be rendered instead of the previous behaviour (the first non-original image).
patrickpatrickpatrick
force-pushed
the
request-variant-image-processing
branch
from
99326a6 to
240dfea
Compare
ChrisBAshton
approved these changes
May 15, 2026
Contributor
ChrisBAshton
left a comment
ChrisBAshton
left a comment
There was a problem hiding this comment.
Before & After screenshots would be good, just to demo the problem this was fixing.
But LGTM
| // transformed variants so we should not use | ||
| // the `original` asset if this is the case | ||
| imgElement.src = previewAsset ? previewAsset.url : assets[0].url | ||
| imgElement.src = previewAsset.url |
Contributor
There was a problem hiding this comment.
Does the comment above this need deleting / editing now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
variantparameter toImageProcessingChecker.Why
To prevent the incorrect variant of an image being used, you can now specify a
variantin theImageProcessingCheckerso that the correct variant of an image will be rendered instead of the previous behaviour (the first non-original image).This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.