Selectively allow unpublishing of historical editions [WHIT-3402]#11456
Open
davidsauntson wants to merge 1 commit into
Open
Selectively allow unpublishing of historical editions [WHIT-3402]#11456davidsauntson wants to merge 1 commit into
davidsauntson wants to merge 1 commit into
Conversation
Previously only GDS Editors and GDS Admins could unpublish historical content. The DBT are about to unpublish and archive a lot of content, so an exception has been made to allow specific users outside of those two GDS roles to unpublish historic content. This change creates the relevant unpublishing permission and allows users with it to perform the unpublishing action for historic documents.
TonyGDS
reviewed
May 15, 2026
| end | ||
| end | ||
|
|
||
| factory :historical_unpublisher, parent: :user do |
Contributor
There was a problem hiding this comment.
historical_content_unpublisher maybe?
TonyGDS
reviewed
May 15, 2026
| assert enforcer_for(@user, historic_edition).can?(:unpublish) | ||
| end | ||
|
|
||
| test "can't perform any other action on an historical document" do |
Contributor
There was a problem hiding this comment.
Might be worth also doing something similar for GDS Admin and GDS Editors, i.e. they can do anything:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only GDS Editors and GDS Admins could unpublish historical content. The DBT are about to unpublish and archive a lot of content, so an exception has been made to allow specific users outside of those two GDS roles to unpublish historic content. See https://gov-uk.atlassian.net/browse/WHIT-3402
This change creates the relevant unpublishing permission and allows users with it to perform the unpublishing action for historic documents.
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.