Add error handling for email sending in send_notification

[aanyacloud]

This PR improves the robustness of the send_notification function by adding error handling around the email sending logic.

Changes:

• Wrapped send_mail in a try-except block
• Added logging for failures

This ensures that notification creation is not interrupted if email sending fails, improving reliability and consistency with existing patterns in the codebase.

Summary

Changes Made
The send_notification() function in web/notifications.py now includes error handling for email sending. The send_mail() call has been wrapped in a try-except block that catches any exceptions during email transmission.

Key Modifications

• Added a try-except block (lines 31-40) around the send_mail() call to gracefully handle email sending failures
• Implemented error logging via logger.error() that records both the target user email address and the exception details
• The function continues to return the created notification object even if email sending fails

Purpose & Impact
This change ensures that notification creation is not interrupted by email service failures, aligning with existing codebase patterns. By catching and logging exceptions rather than allowing them to propagate, the system becomes more resilient. Notifications are successfully persisted to the database regardless of email delivery issues, while detailed error logs enable troubleshooting of email backend problems. This prevents external service failures from disrupting the notification workflow in production environments.

Technical Details

• Lines changed: +10/-7
• No changes to exported or public entity declarations
• Estimated review effort: Medium

[github-actions]

👀 Peer Review Required

Hi @aanyacloud! This pull request does not yet have a peer review.

Before this PR can be merged, please request a review from one of your peers:

• Go to the PR page and click "Reviewers" on the right sidebar.
• Select a team member or contributor to review your changes.
• Once they approve, this reminder will be automatically removed.

Thank you for contributing! 🎉

[github-actions]

🚚 This Repository Is Moving

Hi @aanyacloud, thank you for your contribution!

We are in the process of migrating most of the logic from this repository to our new repository: alphaonelabs/learn.

What this means for your PR

Please do not merge or continue work here. Instead:

1. Review the alphaonelabs/learn repository and familiarize yourself with its tech stack.
2. Adapt your changes to work with that codebase.
3. Open a new Pull Request in alphaonelabs/learn.

This PR has been automatically closed. Once you have opened your PR in the new repository, feel free to reference it here.

Thank you for your understanding and continued support! 🙏

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: alphaonelabs/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: add7588d-a1bc-481f-bbf7-4a54a63428d7

📥 Commits

Reviewing files that changed from the base of the PR and between 7a682c2 and 2f1c4cf.

📒 Files selected for processing (1)

• web/notifications.py

---

Walkthrough

The send_notification() function in web/notifications.py now wraps the send_mail() call with error handling. Exceptions are caught and logged with the recipient email and exception details, while the function continues to return the created notification object.

Changes

Cohort / File(s)	Summary
Error Handling Enhancement web/notifications.py	Added try/except block around send_mail() call to catch exceptions, log errors with email and exception message, while maintaining notification object return.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}