Fixed line width calculation for helm source - #270
Conversation
Fixes alphapapa#248. Closes alphapapa#249. Thanks to Maikol Solis (@maikol-solis) for reporting, and to him and Ihor Radchenko (@yantar92) for helping plan the fix.
.Was resulting in negative values on long entries and the resulting error was being suppressed by `ignore-errors' in the source
|
Thanks for working on this. Looking at the change, I'm not sure if I understand exactly what's happening, or whether this would be the best way to fix it. If the width variable is set to 0 for certain entries, it might result in a string that isn't useful or readable. Can you show me an example of an entry that causes this problem, and what the result is after the fix is applied? |
I'll try to get a more concrete example for you soon, but the current behavior causes any source that would show one of these long entries to show absolutely nothing at all. The behavior when that value gets calculated as 0 is just that it effectively uses the whole original string. Regardless long strings causing that value to be negative and then throw an invisible error will need to be addressed for usability. |
|
Ok, thanks. If you would, since this is a bug fix, please rebase the patch onto the |
|
Created new [cleaner, saner] PR, #271 . |
.Was resulting in negative values on long entries and the resulting
error was being suppressed by `ignore-errors' in the source