Skip to content

Deduplicate the third valid_digest copy in adapters/connected.rs #31

Description

@1wgrumph

Migrated from private source issue alphazede/bran-dev#16

Follow-up from #14 (merged as 39abfdc).

#14 removed the duplicated hex/SHA-256 validator from crates/bran-core/src/agent/delegate.rs, which now uses the shared valid_sha256 in crates/bran-core/src/agent/runtime.rs.

A third byte-identical copy remains at crates/bran-core/src/adapters/connected.rs:545. It is pre-existing on main and was untouched by #14, so deduplicating it there would have been unrelated cleanup outside that change's scope.

Three implementations of the same validator must stay in sync by hand. Fold this one into the shared helper.

Low priority, maintainability only. No known correctness impact.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions