Provide a more helpful error on pip install.#61
Open
danielballan wants to merge 2 commits intoals-computing:masterfrom
Open
Provide a more helpful error on pip install.#61danielballan wants to merge 2 commits intoals-computing:masterfrom
danielballan wants to merge 2 commits intoals-computing:masterfrom
Conversation
Collaborator
|
Thanks for this @danielballan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A somewhat silly first PR, but it might help someone.
I like and always use the pattern of parsing
requirements.txtto populate theinstall_requiresparameter insetup.py. But an annoying restriction to keep in mind is that whileworks with
git+https://...specifications,install_requiresonly accepts proper packages on a packaging index (e.g. PyPI). There is not a good workaround for this as far as I know. All you can do is provide a more helpful error message.Before:
After: