Skip to content

[07] Establish represented-to-live bridge convention#87

Open
alseif0x wants to merge 1 commit into
3.4.3from
19-07-m06-establish-the-represented-live-bridge-convention
Open

[07] Establish represented-to-live bridge convention#87
alseif0x wants to merge 1 commit into
3.4.3from
19-07-m06-establish-the-represented-live-bridge-convention

Conversation

@alseif0x

@alseif0x alseif0x commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Refs #19

QA pending: do not merge until manual/capture validation, CI, and Codex reviewer verdict are complete.

Summary:

  • Documents the represented-to-live intent bridge convention.
  • Adds a small bridge API and converts duel acceptance as the example.
  • Ensures the represented intent is recorded and live mutation is applied once.

Validation reported locally:

  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world --lib
  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server
  • cargo fmt --all -- --check
  • git diff --check

Manual QA pending: duel accept flow in client and capture-clean comparison vs C++.

@alseif0x

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: a549f357c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

QA validation checklist:

  • This PR is mostly runtime plumbing/convention, so validate it as a client smoke test.
  • Log in, enter world, move between nearby areas, target creatures/NPCs, and perform a basic attack/cast.
  • Logout to character select and reconnect with the same client session; visible creatures/NPCs should reload normally.
  • Watch for server crashes, missing nearby spawns, or obvious duplicate/stale object behavior.

If this stays green in checks, it can remain pending user QA; no special gameplay flow is expected beyond regression coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[07] [M0.6] Establish the represented->live bridge convention

1 participant