Skip to content

[05] Add represented player save transaction timer#88

Open
alseif0x wants to merge 2 commits into
3.4.3from
17-05-m04-player-persistence-safety-periodic-save-+-transactions
Open

[05] Add represented player save transaction timer#88
alseif0x wants to merge 2 commits into
3.4.3from
17-05-m04-player-persistence-safety-periodic-save-+-transactions

Conversation

@alseif0x

@alseif0x alseif0x commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Refs #17

QA pending: do not merge until capture/manual runtime validation, CI, and Codex reviewer verdict are complete.

Summary:

  • Adds represented periodic player autosave from PlayerSaveInterval.
  • Wraps current represented CharacterDB save statements in a single transaction.
  • Clears dirty flags only after successful commit.

Validation reported locally:

  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world --lib
  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server
  • cargo fmt --all -- --check
  • git diff --check

Manual QA pending: runtime autosave/restart behavior and persistence consistency under disconnect/crash scenarios.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 256845ab92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/wow-world/src/session.rs
Comment thread crates/wow-world/src/session.rs
Comment thread crates/wow-world/src/session.rs
@alseif0x

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 99cbbbd365

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

QA validation checklist:

  • Log in, change a persistent player value if possible: health/mana by taking damage/casting, money by buying/selling, or XP by killing a mob.
  • Stay online long enough for the periodic save interval, then logout/relogin; the changed values should not roll back.
  • Try a teleport/hearth-style transfer and relog afterward; the character should not be saved at a destination before the transfer actually completes.
  • Verify normal idle play does not cause server crashes or visible stutters around autosave.

Checks are currently green; leave final status pending user QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[05] [M0.4] Player persistence safety: periodic save + transactions

1 participant