Skip to content

[52] Persist innkeeper homebind#92

Open
alseif0x wants to merge 2 commits into
3.4.3from
44-52-m53-hearthstone-bind-innkeeper-set-home-persist-to-db
Open

[52] Persist innkeeper homebind#92
alseif0x wants to merge 2 commits into
3.4.3from
44-52-m53-hearthstone-bind-innkeeper-set-home-persist-to-db

Conversation

@alseif0x

@alseif0x alseif0x commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Refs #44

QA pending: do not merge until manual client QA, CI, and Codex reviewer verdict are complete.

Summary:

  • Loads represented character_homebind on login.
  • Makes innkeeper binder activation persist homebind and send bind packets.
  • Resolves hearthstone HOME destination from represented homebind.

Validation reported locally:

  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world homebind --lib
  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world binder_activate --lib
  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server
  • cargo fmt --all -- --check
  • git diff --check

Manual QA pending: talk to innkeeper, bind, use hearthstone, relog, verify DB persistence.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4759196873

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/wow-world/src/handlers/character.rs Outdated
Comment thread crates/wow-world/src/handlers/character.rs
Comment thread crates/wow-world/src/handlers/character.rs
Comment thread crates/wow-world/src/handlers/character.rs Outdated
@alseif0x

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 816ab060c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

QA validation checklist:

  • Bind at a normal innkeeper outside instances; the client should show the bind success behavior, close/settle the interaction correctly, and update the bind point.
  • Move away, logout/relogin, then use hearthstone; it should return to the saved innkeeper bind location.
  • Test a fresh/new character with no prior homebind row; hearthstone/bind behavior should still have a valid fallback and not no-op.
  • If available, try an innkeeper-like interaction inside an instanceable map; it must not persist an invalid instance homebind.

Checks are currently green; leave final status pending user QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[52] [M5.3] Hearthstone bind / innkeeper set-home (persist to DB)

1 participant