Skip to content

[27] Align text emote DB2 fanout gates#93

Open
alseif0x wants to merge 1 commit into
3.4.3from
50-27-c-chat2-emote-handlers-are-simplified-vs-c++-validationscriptscriteriadb2range
Open

[27] Align text emote DB2 fanout gates#93
alseif0x wants to merge 1 commit into
3.4.3from
50-27-c-chat2-emote-handlers-are-simplified-vs-c++-validationscriptscriteriadb2range

Conversation

@alseif0x

@alseif0x alseif0x commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Refs #50

QA pending: do not merge until capture/manual validation, CI, and Codex reviewer verdict are complete.

Summary:

  • Keeps C++-anchored EmotesText.db2 validation and silent return.
  • Preserves TargetGUID and aligns player fanout gates with C++ world/map/instance/range checks.
  • Re-anchors chat packet comments from C# to C++.

Validation reported locally:

  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world send_text_emote_ --lib
  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world --lib
  • PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server
  • cargo fmt --all -- --check
  • git diff --check

Manual QA pending: client text emotes with valid/missing/out-of-range target and capture-diff vs C++.

@alseif0x

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 0193c73f60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

QA validation checklist:

  • Use common text emotes such as /wave, /dance, /kiss, or /rude near another player/client and confirm nearby players see the expected emote output/animation.
  • Repeat with an NPC or creature targeted; valid target-gated emotes should work, invalid combinations should not grant unexpected behavior.
  • Try an emote with no target and with an out-of-range target if practical; it should not crash or send obviously wrong fanout.
  • Verify normal chat, targeting, movement, and combat remain unaffected.

Checks are currently green; leave final status pending user QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[27] [C#-CHAT.2] Emote handlers are simplified vs C++ (validation/scripts/criteria/DB2/range)

1 participant