[17] Fix character enum flags mapping

[alseif0x]

Refs #53

QA pending: do not merge until character-list manual QA, capture comparison, CI, and Codex reviewer verdict are complete.

Summary:

• Replaces inherited C# character enum flag mapping with C++-anchored helpers.
• Handles rename, ghost, billing lock, declined-name config, Flags2 values, and pet family mapping.
• Preserves packet field order for pet data.

Validation reported locally:

• cargo test -p wow-packet enum_characters_result_preserves_pet_data_field_order_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world enum_character --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server
• cargo fmt --all -- --check
• git diff --check

Manual QA pending: visually validate character list and capture-diff enum response vs C++.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee552dc226

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

QA validation checklist:

• Check the character select screen for normal alive characters: no unexpected disabled/ghost/rename/customization state should appear.
• Check a dead/ghost character from logout to character select; the visible state should match what C++ shows for the same database state.
• If a rename/customization flag can be set in DB, verify it appears on character select without leaking unrelated raw player flags.
• Also test a character logged out in a rest area and compare the character-select state against the C++ server/client behavior.

Note: this PR still has a Codex reviewer disagreement/comment to resolve before it is merge-ready.

[alseif0x]

@codex review

I rechecked the review item against the local C++ source of truth and did not change the code because the requested CHARACTER_FLAG_RESTING mapping is not present in this branch's C++ reference.

C++ anchors checked:

• /home/server/woltk-trinity-legacy/src/server/game/Server/Packets/CharacterPackets.cpp:118-145: EnumCharactersResult::CharacterInfo::CharacterInfo maps ghost, rename, billing lock, declined names, customize/faction/race, and first-login only. It does not map PLAYER_FLAGS_RESTING.
• /home/server/woltk-trinity-legacy/src/server/game/Miscellaneous/SharedDefines.h:1021-1053: there is no named CHARACTER_FLAG_RESTING; bit 0x20 is CHARACTER_FLAG_UNK6.

Given AGENTS.md requires C++ as source of truth, this PR intentionally keeps resting out of character enum flags while preserving ghost/rename/customization handling.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee552dc226

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

@codex review

Pushed 89c9e28 for the actionable current review item: character enum now executes the C++ equivalent before the enum select, so elapsed temporary bans are cleared before can map to . Added and validated with:

running 1 test
test handlers::character::tests::enum_character_query_statements_expire_bans_before_select_like_cpp ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 2634 filtered out; finished in 0.00s

The resting enum flag item remains intentionally not changed because local C++ does not map for this packet in this branch.

[alseif0x]

@codex review

Correction for the previous comment: pushed 89c9e286 for the actionable current review item. Character enum now executes the C++ CHAR_DEL_EXPIRED_BANS equivalent before the enum select, so elapsed temporary bans are cleared before banned_guid can map to CHARACTER_FLAG_LOCKED_BY_BILLING.

Validation:

• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world enum_character_query_statements_expire_bans_before_select_like_cpp --lib
• cargo fmt --all -- --check
• git diff --check
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server

The resting enum flag item remains intentionally not changed because local C++ CharacterPackets.cpp:118-145 does not map PLAYER_FLAGS_RESTING for this packet in this branch.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 89c9e286f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".