feat: Add docstrings; Add Support for UserDict in _transfer_to_device#19
Open
proshian wants to merge 2 commits intoalstonlo:mainfrom
Open
feat: Add docstrings; Add Support for UserDict in _transfer_to_device#19proshian wants to merge 2 commits intoalstonlo:mainfrom
proshian wants to merge 2 commits intoalstonlo:mainfrom
Conversation
Add and update docstrings for methods: * train_outputs * _model_params * _model_make_functional * _model_reinsert_params * _loader_wrapper * _loss_grad_loader_wrapper * _hvp_at_batch
proshian
changed the title
When using huggingface transformers library, it's common for the batch to be of type BatchEncoding which is a subtype of UserDict, but is NOT a subtype of dict. This update fixes the issue by adding support for UserDict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
torch-influence&transformers: Updates the_transfer_to_devicemethod to supportUserDictinstances. The Hugging FaceBatchEncodingclass, which is a common otype for a batch in the library, inherits fromUserDictbut not fromdict. This change ensures that_transfer_to_devicecorrectly handles these batch types, fixing error-raising in_transfer_to_devicethat preventedtorch-influencefrom working seamlessly with the transformers library.