Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a formatter setting to preserve trailing commas in the Altive lints configuration.
- Adds a
formattersection withtrailing_commas: preserveto the YAML config.
Comments suppressed due to low confidence (1)
packages/altive_lints/lib/altive_lints.yaml:15
- Add or update tests to verify that the
trailing_commas: preservesetting is honored by the formatter.
trailing_commas: preserve
|
|
||
| formatter: | ||
| # The default setting conflicts with require_trailing_commas. | ||
| trailing_commas: preserve |
There was a problem hiding this comment.
Consider adding or updating README or inline comments to explain the new formatter section and its effect on code formatting.
riscait
force-pushed
the
preserve-trailing_commas
branch
from
f5e2e5a to
2538fc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🙌 What's Done
trailing_commas: preserve🤼 Desired Review Method
Note
It is possible that a reviewer's will may cause a method to be implemented that is not selected.
📝 Additional Notes
Pre-launch Checklist